Delete feedback

[loiswells97]

Status

• Related to https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/948

What's changed?

• Added route to allow users to delete feedback
• Owners can read and delete any feedback within the school
• Teachers can only delete feedback for projects within their class

[Copilot]

Pull request overview

This PR implements the ability for teachers and school owners to delete feedback on student projects. The implementation adds a DELETE endpoint to the feedback API, updates authorization rules in CanCanCan, and includes comprehensive test coverage for different user roles.

Key Changes

• Added destroy action to the Feedback API that allows authorized users to delete feedback
• Updated authorization rules to permit school owners to delete any feedback in their school and teachers to delete feedback for projects in their classes
• Created a new Feedback::Delete operation following the repository's domain operation pattern

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
config/routes.rb	Added destroy to the feedback resources to expose the DELETE endpoint
app/controllers/api/feedback_controller.rb	Implemented destroy action that calls the Delete operation and returns appropriate status codes
app/models/ability.rb	Added :destroy permission for school owners (all school feedback) and teachers (class projects)
lib/concepts/feedback/delete.rb	Created Delete operation with error handling and Sentry integration
spec/models/ability_spec.rb	Added authorization tests verifying destroy permissions for different roles
spec/features/feedback/deleting_feedback_spec.rb	Added feature tests for successful deletion, forbidden access, and non-existent feedback scenarios
spec/concepts/feedback/delete_spec.rb	Added unit tests for the Delete operation covering success and failure cases

[jamiebenstead]

LGTM