Upgrade to latest 3.x Ruby #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrade to newer bundler so ruby version can be specified in ruby file. I'm doing this primarilly because I can't run Rubocop locally due to older version of ruby being built on older versions of OpenSSL which don't accept the certificates for our remote rubocop config.
zetter-rpf
force-pushed
the
upgrade-ruby-to-3.4
branch
from
2ee9209 to
77be67f
Compare
It looks like ruby 3.4.x is no longer being built for bullseye so use a more recent debian OS. Also, python2-dev is no longer available as a package. As far as I can see python isn't used so remove it.
Copy across the .ruby-version file so bundler knows what version to use. Also --path is no longer supported so remove it.
This wasn't working correctly as it was looking for files that didn't exist.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the application’s runtime/tooling to Ruby 3.4.8 and aligns local/CI/container environments accordingly, including upgrading Bundler to support sourcing the Ruby version from .ruby-version.
Changes:
- Bump Ruby version to 3.4.8 across
.ruby-version,.tool-versions, CircleCI, and Docker. - Update Bundler version in
Gemfile.lockand switch Gemfile Ruby declaration to read from.ruby-version. - Add explicit
base64andcsvdependencies (now treated as gems in newer Ruby setups).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Gemfile.lock | Updates Ruby version and Bundler version; adds base64/csv dependencies. |
| Gemfile | Reads Ruby version from .ruby-version; adds base64/csv gems. |
| Dockerfile | Moves base image to Ruby 3.4.8 on Debian trixie; adjusts bundle/binstubs setup and COPY inputs. |
| .tool-versions | Updates asdf Ruby version to 3.4.8. |
| .ruby-version | Updates Ruby version file to ruby-3.4.8. |
| .circleci/config.yml | Updates CI Ruby images to 3.4 series. |
Comments suppressed due to low confidence (1)
.circleci/config.yml:8
- CI images were bumped to Ruby 3.4, but the lockfile now specifies
BUNDLED WITH 4.0.5. If thecimg/ruby:3.4*images (or theruby/install-depsorb) don’t provide Bundler 4.x by default,bundle installwill fail with a “use Bundler 4.x” error. Consider explicitly installing/pinning Bundler 4.0.5 in this job (or configuring the orb to use it) to keep CI deterministic.
docker:
- image: "cimg/ruby:3.4"
steps:
- checkout
- ruby/install-deps
- ruby/rubocop-check:
Bundler and most version managers support .tool-versions now so it's one less place to keep up to date
Suggested by Copilot, I don't think it is more secure as it already is key verified.
jamiebenstead
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Upgrade to ruby 3.4.8 (the latest 3.x.x release)
Also upgrade to newer bundler (4.0.5) so ruby version can be specified in the .ruby-version file.
I'm doing this primarily because I can't run Rubocop locally due to older versions of ruby being built on older versions of OpenSSL which don't accept the certificates for our remote Rubocop config. There are other ways to solve this problem, but we get other benefits from being on a newer Ruby release.
Steps to perform after deploying to production
I will check this in the staging environment