Merged
Conversation
Based on the instructions here: https://digital-docs.rpf-internal.org/docs/technology/codebases-and-products/editor/processes/code-editor-for-education/removing-teachers Key differences: - The instructions say to connect to Profile's Postgres instance to lookup the user ID, but we instead use the `UserInfoApiClient` for that here. - This task doesn't ask for a school, since it should not be possible for the user to have roles in more than one school (see `role.rb`).
Test coverage89.3% line coverage reported by SimpleCov. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an operational Rake task to remove a teacher role from a school user by email address, aligning with the documented “removing teachers” process while using UserInfoApiClient for user lookup.
Changes:
- Introduce
remove_teacher:runRake task to delete a user’s teacher role by email. - Add RSpec task coverage for the new Rake task’s main success and early-exit paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/tasks/remove_teacher.rake | Implements the remove_teacher:run task using UserInfoApiClient lookup and role deletion. |
| spec/lib/tasks/remove_teacher_spec.rb | Adds task specs covering user-not-found, no-teacher-role, and successful removal scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the instructions here:
https://digital-docs.rpf-internal.org/docs/technology/codebases-and-products/editor/processes/code-editor-for-education/removing-teachers
Key differences:
UserInfoApiClientfor that here.role.rb).Status
What's changed?
Adds Rake task to remove a user's current teacher role given their email address.
Steps to perform after deploying to production
Update https://digital-docs.rpf-internal.org/docs/technology/codebases-and-products/editor/processes/code-editor-for-education/removing-teachers.