Merged
Conversation
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
force-pushed
the
danhalson/1318-integrate-stylelint-into-ci
branch
from
45255fd to
c8e1b18
Compare
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
force-pushed
the
danhalson/1318-integrate-stylelint-into-ci
branch
from
c8e1b18 to
85487a5
Compare
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
force-pushed
the
danhalson/1318-integrate-stylelint-into-ci
branch
from
93b29f4 to
67fa85b
Compare
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
changed the title
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
force-pushed
the
danhalson/1318-integrate-stylelint-into-ci
branch
from
8fef540 to
cf663c7
Compare
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
force-pushed
the
danhalson/1318-integrate-stylelint-into-ci
branch
from
cf663c7 to
8fef540
Compare
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
…ate-stylelint-into-ci
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
danhalson
temporarily deployed
to
previews/1367/merge
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Integrates Stylelint into the CI pipeline and updates the codebase/tooling to resolve existing Stylelint (and related formatting) issues, including a broad set of SCSS logical-property updates and devcontainer/editor configuration to surface lint feedback locally.
Changes:
- Adds a Stylelint step to the CI workflow (conditionally triggered via
paths-filter). - Updates Stylelint + related tooling dependencies (plus associated lockfile changes).
- Fixes existing SCSS lint issues (logical properties, Sass interpolation fixes, etc.) and updates documentation/devcontainer settings.
Reviewed changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci-cd.yml |
Adds a Stylelint CI step gated by SCSS file changes. |
.devcontainer/devcontainer.json |
Enables ESLint/Stylelint validation in the devcontainer’s VS Code settings. |
.stylelintrc |
(Context) Stylelint config extends stylelint-config-recommended-scss and enables stylelint-use-logical. |
package.json |
Bumps Stylelint + related tooling (Prettier/PostCSS/etc.). |
yarn.lock |
Lockfile updates reflecting the dependency upgrades. |
README.md |
Adds “Linting” section describing CI + local lint commands. |
CHANGELOG.md |
Notes CI/devcontainer lint integration and lint fixes. |
src/assets/stylesheets/*.scss |
Resolves Stylelint errors (logical properties, overflow-wrap, Sass interpolation, etc.). |
src/assets/stylesheets/App.scss |
Refactors focus styling into a placeholder selector reused by a/button. |
src/utils/ResizableWithHandle.js |
Formatting change (indentation). |
src/components/Menus/Sidebar/Sidebar.jsx |
Formatting change (indentation). |
src/components/Editor/Runners/PythonRunner/OutputViewToggle.jsx |
Formatting change (indentation). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zetter-rpf
reviewed
Mar 12, 2026
Comment on lines
12
to
+21
| - Introduce @testing-library for cypress | ||
| - Update cypress (#1283) | ||
| - Dev container highlights eslint & stylelint detections (#1367) | ||
| - CI runs stylelint (#1367) | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Clear loaded modules to remove state between runs (#1287) | ||
| - Fix intermitently failing dropdown test (#1285) | ||
| - Fix a handful of linting issues across both eslint and stylelint (#1367) |
Contributor
There was a problem hiding this comment.
We changed the release process to use Github to generate the changelog from merged PRs so this file is no longer used. Instead the PR title will be added to the changelog (and the PR linked to).
Contributor
Author
There was a problem hiding this comment.
ah, that's good news! do you want me to remove this then
Contributor
There was a problem hiding this comment.
Up to you, but it won't be used as it is.
zetter-rpf
approved these changes
Mar 12, 2026
Contributor
zetter-rpf
left a comment
zetter-rpf
left a comment
There was a problem hiding this comment.
It's great to have our styles linted again ☑️ ☑️ ☑️ ☑️
jamiebenstead
pushed a commit
that referenced
this pull request
Mar 13, 2026
jamiebenstead
pushed a commit
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1318