Fix useEffect web component warnings by create-issue-branch[bot] · Pull Request #674 · RaspberryPiFoundation/editor-ui

create-issue-branch · 2023-09-28T09:18:15Z

closes #668

github-actions · 2023-09-28T09:21:34Z

Github Run 6336965403
Test coverage: 78%

github-actions · 2023-09-28T09:22:11Z

Github Run 6336964949
Test coverage: 78%

github-actions · 2023-10-03T10:12:30Z

Github Run 6391570179
Test coverage: 78%

…hub.com:RaspberryPiFoundation/editor-ui into issues/668-Fix_useEffect_web_component_warnings

github-actions · 2023-10-03T10:22:37Z

Github Run 6391656626
Test coverage: 78%

github-actions · 2023-10-03T10:29:08Z

Github Run 6391727797
Test coverage: 78%

loiswells97 · 2023-10-03T10:31:00Z

src/components/WebComponent/Project/WebComponentProject.js

    }, 2000);
    setTimeoutId(id);
-  }, [project]);
+  }, [project, timeoutId, webComponent]);


Are you sure this doesn't make the browser go crazy? The reason the timeoutId was left out initially was because it was causing constant rerenders (which was throwing up a warning in the console)

Will run it locally and see the console, thanks a lot for flagging it up

@loiswells97 I wrapped the method to clear any existing timeout when the dependencies change. Could you please check the console if there are any issues? I couldn't replicate any console issue

Okay, I took a look and I'm not sure the custom event is still being triggered. For example, if you go to the web component test page it should print the code to the console 2 seconds after it's changed (in response to the codeChanged event), but that isn't happening anymore.

@loiswells97 I removed the reset of timeoutId. I wonder if adding a timeout clearing function (clearing interval) might be a good idea to include the timeoutId within the useEffect() dependencies and also make sure it's not causing any console issues.

I think this is still behaving strangely because it now triggers the event multiple times (I think once for each key press) whereas it should only trigger once 2 seconds after the user stops typing

On your point, I'm not sure, I feel like my understanding of the timeout stuff is sketchy at best

github-actions · 2023-10-03T10:31:01Z

Github Run 6391762811
Test coverage: 78%

github-actions · 2023-10-03T11:08:12Z

Github Run 6392120030
Test coverage: 78%

github-actions · 2023-10-03T12:13:39Z

Github Run 6392739050
Test coverage: 78%

github-actions · 2023-10-09T13:00:54Z

Github Run 6456941484
Test coverage: 78%

github-actions · 2023-10-10T10:47:23Z

Github Run 6468198814
Test coverage: 79%

github-actions · 2023-10-10T11:45:23Z

Github Run 6468762676
Test coverage: 79%

github-actions · 2023-10-10T13:48:44Z

Github Run 6470211461
Test coverage: 79%

loiswells97 · 2023-10-10T13:48:35Z

src/components/WebComponentProject/WebComponentProject.jsx

  const project = useSelector((state) => state.editor.project);
  const codeRunTriggered = useSelector(
-    (state) => state.editor.codeRunTriggered,
+    (state) => state.editor.codeRunTriggered


I think this might have broken the linting?

loiswells97 · 2023-10-10T13:49:15Z

CHANGELOG.md


 ## Unreleased

+## [0.19.2] - 2023-10-10


We normally only add this line when we cut a release, and leave all the current stuff under Unreleased

github-actions · 2023-10-10T13:49:49Z

Github Run 6470228787
Test coverage: 79%

github-actions · 2023-10-10T14:20:30Z

Github Run 6470596599
Test coverage: 79%

loiswells97

Looks good to me 🎉

github-actions · 2023-10-11T20:21:30Z

Github Run 6487581264
Test coverage: 79%

…hub.com:RaspberryPiFoundation/editor-ui into issues/668-Fix_useEffect_web_component_warnings

github-actions · 2023-10-11T20:26:10Z

Github Run 6487625583
Test coverage: 79%

loiswells97

Looks great 👍

Create draft PR for #668

d73b3bf

create-issue-branch bot temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings September 28, 2023 09:18 Inactive

Merge branch 'main' into issues/668-Fix_useEffect_web_component_warnings

c4090fb

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 3, 2023 10:09 — with GitHub Actions Inactive

Magdalena Jadach added 2 commits October 3, 2023 11:17

Fix missing dependencies

4576cab

Merge branch 'issues/668-Fix_useEffect_web_component_warnings' of git…

2e18e44

…hub.com:RaspberryPiFoundation/editor-ui into issues/668-Fix_useEffect_web_component_warnings

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 3, 2023 10:17 — with GitHub Actions Inactive

Fix warnings for Editor slice

eb52765

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 3, 2023 10:24 — with GitHub Actions Inactive

magdalenajadach marked this pull request as ready for review October 3, 2023 10:24

Revert dispatch change

776f986

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 3, 2023 10:27 — with GitHub Actions Inactive

loiswells97 reviewed Oct 3, 2023

View reviewed changes

Wrap the Timeout fucntion with cleanup

25d4c35

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 3, 2023 11:05 — with GitHub Actions Inactive

magdalenajadach self-assigned this Oct 3, 2023

Revert a funcitn to clean up a timeout

591171e

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 3, 2023 12:09 — with GitHub Actions Inactive

Move dispatch to another useEffect, clear timeout

6668a35

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 9, 2023 12:57 — with GitHub Actions Inactive

Play with the condiotional rendering

d167226

magdalenajadach mentioned this pull request Oct 10, 2023

Fix timerId issue within Web Component #696

Closed

Remove unused hook

7222ff9

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 10, 2023 10:44 — with GitHub Actions Inactive

Update the timer function

0214b15

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 10, 2023 11:40 — with GitHub Actions Inactive

remove comments, fix changelog

518124f

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 10, 2023 13:45 — with GitHub Actions Inactive

Fix changelog

f821ac2

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 10, 2023 13:46 — with GitHub Actions Inactive

loiswells97 reviewed Oct 10, 2023

View reviewed changes

Fix linting and changelog

9f78af6

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 10, 2023 14:16 — with GitHub Actions Inactive

loiswells97 previously approved these changes Oct 10, 2023

View reviewed changes

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 10, 2023 15:17 — with GitHub Actions Inactive

Merge branch 'main' into issues/668-Fix_useEffect_web_component_warnings

1a3753b

magdalenajadach temporarily deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 11, 2023 20:18 — with GitHub Actions Inactive

Magdalena Jadach added 2 commits October 11, 2023 21:22

Rename variable to something more meaningful

c8eb3b6

Merge branch 'issues/668-Fix_useEffect_web_component_warnings' of git…

9c181f6

…hub.com:RaspberryPiFoundation/editor-ui into issues/668-Fix_useEffect_web_component_warnings

magdalenajadach dismissed loiswells97’s stale review via 9c181f6 October 11, 2023 20:23

magdalenajadach deployed to previews/issues/668-Fix_useEffect_web_component_warnings October 11, 2023 20:23 — with GitHub Actions View deployment

loiswells97 approved these changes Oct 12, 2023

View reviewed changes

magdalenajadach merged commit e61900a into main Oct 12, 2023

magdalenajadach deleted the issues/668-Fix_useEffect_web_component_warnings branch October 12, 2023 08:34

Conversation

create-issue-branch bot commented Sep 28, 2023

Uh oh!

github-actions bot commented Sep 28, 2023

Uh oh!

github-actions bot commented Sep 28, 2023

Uh oh!

github-actions bot commented Oct 3, 2023

Uh oh!

github-actions bot commented Oct 3, 2023

Uh oh!

github-actions bot commented Oct 3, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 3, 2023

Uh oh!

github-actions bot commented Oct 3, 2023

Uh oh!

github-actions bot commented Oct 3, 2023

Uh oh!

github-actions bot commented Oct 9, 2023

Uh oh!

github-actions bot commented Oct 10, 2023

Uh oh!

github-actions bot commented Oct 10, 2023

Uh oh!

github-actions bot commented Oct 10, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 10, 2023

Uh oh!

github-actions bot commented Oct 10, 2023

Uh oh!

loiswells97 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 11, 2023

Uh oh!

github-actions bot commented Oct 11, 2023

Uh oh!

loiswells97 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants