Add test route to avoid the shadow root/having to render the global nav #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage: 100% |
patch0
changed the title
patch0
changed the title
grega
previously approved these changes
Jul 3, 2024
Member
grega
left a comment
grega
left a comment
There was a problem hiding this comment.
Nice 👍
Airing one mostly unrelated thought; we can drop Ruby 2.7 support here (all apps using rpi-auth are >=3)
Contributor
Author
Yes, yes we can! I was slightly struggling with it tbh, but I thought it would be better done in a separate PR. |
grega
approved these changes
Jul 4, 2024
Merged
patch0
added a commit
that referenced
this pull request
Jul 4, 2024
## Added - Test controller/view to allow apps to log in without having to interact with the RPF Global Nav component. (#70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a login page to use in testing to avoid having to render the rpf-global-nav in tests that don't need JS.
What's changed
/rpi_auth/testwhich shows a login and sign-up button that can be used in test scenarioslog_in(user:)andstub_auth_for(user:)methods that we've replicated in a lot of places.rubygemsversion during CI because one of the Gems doesn't build with the older version of Rubygems that ships with Ruby 2.7