Avoid LoadError when using rake #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it wasn't even possible to list the rake tasks, because this `rails/tasks/statistics.rake` file does not exist. It was added in a very large initial commit [1] which doesn't mention it in the commit note, so I have no idea what its origins are. [1]: 79600c9
Test coverage: 100.0% |
Contributor
Author
|
@grega I've belated realised this probably related to a rake file provided by rails, i.e. Also it doesn't make much sense to me that this gem should be using this rails-related rake file. I suspect it was copied from a newly generated rails app. So I'm still pretty happy that the change in this PR is OK, but let me know if you want me to do any more digging. |
Member
|
I suspect it was a file generated when bootstrapping the gem originally (and as you've suggested, that was probably the result of extracting the gem from a Rails proof-of-concept app). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it wasn't even possible to list the rake tasks, because this
rails/tasks/statistics.rakefile does not exist.It was added in a very large initial commit which doesn't mention it in the commit note, so I have no idea what its origins are.