Fix use of User#expires_at in SpecHelpers#stub_auth_for
#82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage: 100.0% |
grega
previously approved these changes
Apr 16, 2025
Member
|
Thanks for these improvements @floehopper, much appreciated. |
Previously, if `User#expires_at` was defined, but it was set to `nil`, the `expires_in` calculation was returning a large negative integer. This was because `nil.to_i` is 0 and thus `user.expires_at.to_i - Time.zone.now.to_i` was a value like `-1744820986` (for 2025-04-16 17:30). This isn't a problem in e.g. `code-club-frontend`, because the user factory sets `User#expires_at` to a time a random number of seconds in the future, i.e. `rand(60..300).seconds.from_now [1]. We've had to do something similar in `experience-cs` [2], but I think a better solution is to default to using the 3600 fallback value if `User#expires_at` is `nil` just like we do if `User#expires_at` is not defined. [1]: https://github.com/RaspberryPiFoundation/code-club-frontend/blob/f7e965798d910584fed0d1eb7867f32a899f9ce8/spec/factories/user.rb#L21 [2]: https://github.com/RaspberryPiFoundation/experience-cs/blob/47d11bd60da7b7bd93968534542f84edca4054aa/spec/factories/user.rb#L5
floehopper
force-pushed
the
fix-use-of-user-expires-at-in-spec-helpers
branch
from
c4d19f0 to
64bf109
Compare
Contributor
Author
|
@grega Thanks - just realised I forgot to add a changelog entry - force-pushing that now which will probably require another approval! |
grega
approved these changes
Apr 16, 2025
Contributor
Author
|
Thanks, @grega. I've just run the changes against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
User#expires_atwas defined, but it was set tonil, theexpires_incalculation was returning a large negative integer. This was becausenil.to_iis 0 and thususer.expires_at.to_i - Time.zone.now.to_iwas a value like-1744820986(for 2025-04-16 17:30) which meant the credentials were effectively immediately expired some time ago.This isn't a problem in e.g.
code-club-frontend, because the user factory setsUser#expires_atto a time a random number of seconds in the future, i.e. `rand(60..300).seconds.from_now.We've had to do something similar in
experience-cs, but I think a better solution is to default to using the 3600 fallback value ifUser#expires_atisniljust like we do ifUser#expires_atis not defined.