Module authorizationserver #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added http client implementation based on Apache Http Added wrapers for session token, credentials and secret Added Reader implementation for reading data stored in storage Took 11 hours 56 minutes
There are still missing some method implementations of abstract Module class Took 1 hour 36 minutes
…nserver # Conflicts: # Manager/pom.xml # Manager/src/main/java/io/raspberrywallet/manager/cryptography/crypto/exceptions/DecryptionException.java # Manager/src/main/java/io/raspberrywallet/manager/modules/ExampleModule.java # Manager/src/main/java/io/raspberrywallet/manager/modules/Module.java Took 8 minutes
Changed storing secret logic for authorization server module, now Server is storing encryption key, that is used for key part encryption input from manager Not working version, needs some debugging Took 1 hour 25 minutes
Took 35 minutes
stanbar
requested changes
Oct 27, 2018
Manager/src/main/java/io/raspberrywallet/manager/common/http/ApacheSecuredHttpClient.java
Outdated
Show resolved
Hide resolved
Manager/src/main/java/io/raspberrywallet/manager/common/http/ApacheHttpClient.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public HttpResponse sendPOSTRequest(Form body, String endpoint) throws IOException { | ||
| org.apache.http.client.HttpClient client = HttpClients.createDefault(); |
Contributor
There was a problem hiding this comment.
It would be nice if you could reuse OkHttpClient with Jackson, it's already in our dependencies, and seems to be much smaller and have nicer API
Manager/src/main/java/io/raspberrywallet/manager/common/readers/StringReader.java
Outdated
Show resolved
Hide resolved
Manager/src/main/java/io/raspberrywallet/manager/common/readers/WalletUUIDReader.java
Show resolved
Hide resolved
Manager/src/main/java/io/raspberrywallet/manager/modules/Module.java
Outdated
Show resolved
Hide resolved
...n/java/io/raspberrywallet/manager/modules/authorizationserver/AuthorizationServerModule.java
Show resolved
Hide resolved
Removed unused StringReader class Removed unused host parameter from HttpClients constructors Changed access modifiers from protected to public in Module class Took 42 minutes
Contributor
Author
|
@stasbar please review again, I made changes that you asked for, except for okhttp clients, due to some problems, Apache is fine for now, will refactor it sometime to okhttp |
stanbar
requested changes
Oct 29, 2018
Manager/src/main/java/io/raspberrywallet/manager/common/http/SecuredApacheApacheHttpClient.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/io/raspberrywallet/manager/common/http/UnsecuredApacheApacheHttpClient.java
Outdated
Show resolved
Hide resolved
Took 24 minutes
Took 4 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #50