Skip to content

Extensions and skill tidy#57

Merged
RawToast merged 6 commits intomasterfrom
extensions
Jan 12, 2026
Merged

Extensions and skill tidy#57
RawToast merged 6 commits intomasterfrom
extensions

Conversation

@RawToast
Copy link
Copy Markdown
Owner

@RawToast RawToast commented Jan 12, 2026

Summary by CodeRabbit

  • Documentation

    • Removed the "writing-skills" guides, best-practices, and persuasion reference from docs and the public skills listing.
  • Chores

    • Changed default editor formatter and updated editor recommendations/settings.
    • Updated dev tooling versions and the project package manager.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

Removed the writing-skills documentation directory (three Markdown files), deleted the skill entry from AGENTS.md, updated VSCode recommendations and formatter settings to prefer OXC, and bumped dev tooling: turbo to 2.7.3 and packageManager bun to 1.3.5.

Changes

Cohort / File(s) Summary
Writing-skills Documentation Removal
.agent/skills/writing-skills/SKILL.md, .agent/skills/writing-skills/anthropic-best-practices.md, .agent/skills/writing-skills/persuasion-principles.md
Deleted three comprehensive documentation files (~1,900+ lines total) covering skill authoring, model-specific best practices, and persuasion principles.
Skill Registry Update
AGENTS.md
Removed the "writing-skills" entry from the Available Skills section.
VSCode Configuration
.vscode/extensions.json, .vscode/settings.json
Switched recommended/default formatter from Prettier to OXC, removed a recommended extension, added Prettier to unwanted recommendations, and adjusted formatter mappings.
Dependency / Manifest Updates
package.json
Upgraded devDependency turbo 2.6.3→2.7.3 and updated packageManager bun 1.3.0→1.3.5.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰
I nibbled the old docs with a soft little hop,
Pulled pages away and gave the branch a chop.
Turbo and Bun did a jaunty new dance,
OXC trimmed the lines — concise by chance.
A rabbit's small clap for the repo's fresh hop.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Extensions and skill tidy' accurately reflects the main changes: removing the writing-skills, updating VS Code extensions/settings, and bumping package versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.31%. Comparing base (2f61959) to head (c8ad487).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          14       14           
  Lines        2162     2162           
=======================================
  Hits         2104     2104           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.vscode/settings.json (1)

17-21: Inconsistent Prettier reference remains in codeActionsOnSave.

Line 17 switches the default formatter to OXC, but line 20 still references "source.organizeImports.prettier". Since the project is moving away from Prettier, this action may no longer work as expected or could be a stale reference.

Consider updating or removing this line if OXC handles import organization, or verify that Prettier is still intended for this specific task.

🤖 Fix all issues with AI agents
In @.vscode/extensions.json:
- Around line 2-8: In the extensions.json JSON blob, remove the duplicate
"oxc.oxc-vscode" entry from the recommendations array and delete
"esbenp.prettier-vscode" from the recommendations array so it only appears (if
desired) in unwantedRecommendations; ensure the recommendations array contains
each extension ID only once and that "esbenp.prettier-vscode" is not listed in
recommendations to avoid the contradiction between the "recommendations" and
"unwantedRecommendations" keys.
🧹 Nitpick comments (1)
.vscode/settings.json (1)

27-27: Consider updating the nesting parent key.

Using .prettierrc.json as the parent for OXC config files (.oxfmtrc.json, .oxlintrc.json) is semantically inconsistent since the project is moving away from Prettier. If .prettierrc.json is removed in the future, this nesting rule will have no effect.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9143edf and 0818dde.

⛔ Files ignored due to path filters (2)
  • .agent/skills/writing-skills/graphviz-conventions.dot is excluded by !**/*.dot
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • .agent/skills/writing-skills/SKILL.md
  • .agent/skills/writing-skills/anthropic-best-practices.md
  • .agent/skills/writing-skills/persuasion-principles.md
  • .vscode/extensions.json
  • .vscode/settings.json
  • AGENTS.md
  • package.json
💤 Files with no reviewable changes (4)
  • AGENTS.md
  • .agent/skills/writing-skills/persuasion-principles.md
  • .agent/skills/writing-skills/SKILL.md
  • .agent/skills/writing-skills/anthropic-best-practices.md
🧰 Additional context used
🧠 Learnings (8)
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Use 2 spaces for indentation, no semicolons, trailing commas (ES5), 80 character line width

Applied to files:

  • .vscode/settings.json
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Organize imports as: built-in → third-party → local; always use double quotes

Applied to files:

  • .vscode/settings.json
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Applies to **/*.{ts,tsx} : Export inferred Zod types; keep strict TypeScript with `noUncheckedIndexedAccess` and `noUnusedLocals` enabled

Applied to files:

  • .vscode/settings.json
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Build the project with `bun zenko build` or `turbo build`

Applied to files:

  • package.json
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Applies to packages/zenko/dist/** : Never manually edit `packages/zenko/dist` as it is generated

Applied to files:

  • package.json
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Require Bun 1.3+, Node >=18; run all scripts from the workspace root

Applied to files:

  • package.json
📚 Learning: 2025-10-12T14:20:34.939Z
Learnt from: RawToast
Repo: RawToast/zenko PR: 1
File: package.json:20-20
Timestamp: 2025-10-12T14:20:34.939Z
Learning: In package.json scripts, "bun run --cwd <workspace>" without a script name is a valid helper alias pattern that forwards additional arguments. For example, a script like "zenko": "bun run --cwd packages/zenko" can be invoked as `bun zenko build` which forwards "build" to the workspace package, effectively running `bun run --cwd packages/zenko build`. This is an intentional design for flexible workspace helpers, not an error.

Applied to files:

  • package.json
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Run tests with `bun zenko test` or `turbo test`; use `bun zenko test -u` to refresh snapshots; verify coverage with `bun zenko coverage`

Applied to files:

  • package.json
🔇 Additional comments (2)
package.json (2)

20-22: The self-referential dependency is not an issue. In a Bun monorepo with a private workspace root (as shown by "private": true and "workspaces": ["packages/*"]), the pattern "@zenko/root": "." is a legitimate and intentional design for workspace dependency resolution. This allows workspace packages to reference the root package and is a standard practice in Bun monorepos.

Likely an incorrect or invalid review comment.


28-33: Turbo 2.7.3 and Bun 1.3.5 are stable and appropriate choices.

Both versions exist and are production-ready. Turbo 2.7.3 is a stable release (latest is 2.7.4, but 2.7.3 is current enough). Bun 1.3.5 (released December 17, 2025) includes important stability fixes for macOS, TLS, Windows WebSocket handling, and Node.js compatibility, aligning well with the project's Bun 1.3+ requirement.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.vscode/extensions.json:
- Around line 2-7: The recommendations list contains a duplicate entry for
"esbenp.prettier-vscode" which also appears in unwantedRecommendations; edit the
.vscode/extensions.json to remove "esbenp.prettier-vscode" from the
"recommendations" array (leave it only in "unwantedRecommendations") so the
"recommendations" and "unwantedRecommendations" arrays are no longer
contradictory.
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0818dde and 90ef8bd.

📒 Files selected for processing (2)
  • .vscode/extensions.json
  • .vscode/settings.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .vscode/settings.json

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @package.json:
- Line 25: The package.json lists an unavailable turbo version ("turbo":
"2.7.3") which will fail installs; update the "turbo" dependency entry to a
published stable version (for example "2.5.6") or to a valid canary tag if you
intentionally need a prerelease (e.g., "2.7.3-canary.0"), then run a fresh
install to verify resolution; locate the "turbo" field in package.json and
change its version string accordingly and update lockfile by reinstalling.
🧹 Nitpick comments (1)
package.json (1)

28-30: Align engines.bun with the packageManager version.

The engines.bun constraint is >=1.2.22, but the packageManager specifies bun@1.3.5 and the project requires Bun 1.3+. Update the engines constraint to match:

♻️ Suggested fix
   "engines": {
-    "bun": ">=1.2.22"
+    "bun": ">=1.3.0"
   },
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90ef8bd and 4277fb9.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .vscode/extensions.json
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .vscode/extensions.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Require Bun 1.3+, Node >=18; run all scripts from the workspace root

Applied to files:

  • package.json
📚 Learning: 2026-01-11T11:47:24.729Z
Learnt from: CR
Repo: RawToast/zenko PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T11:47:24.729Z
Learning: Build the project with `bun zenko build` or `turbo build`

Applied to files:

  • package.json

@RawToast RawToast merged commit 0764e9a into master Jan 12, 2026
6 checks passed
@RawToast RawToast deleted the extensions branch January 12, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant