Skip to content

fix(core): retain lazy values before materializing #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singaraiona merged 1 commit into from
May 5, 2026
Merged

fix(core): retain lazy values before materializing #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/core/ipc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,7 +1141,8 @@ ray_t* ray_ipc_send(int64_t handle, ray_t* msg)
{
bool owned = false;
if (ray_is_lazy(msg)) {
msg = ray_lazy_materialize(msg);
ray_retain(msg);
msg = ray_lazy_materialize(msg); /* consumes the retain */
if (RAY_IS_ERR(msg)) return msg;
owned = true;
}
Expand Down Expand Up @@ -1218,7 +1219,8 @@ ray_err_t ray_ipc_send_async(int64_t handle, ray_t* msg)
{
bool owned = false;
if (ray_is_lazy(msg)) {
msg = ray_lazy_materialize(msg);
ray_retain(msg);
msg = ray_lazy_materialize(msg); /* consumes the retain */
if (RAY_IS_ERR(msg)) {
ray_err_t code = ray_err_from_obj(msg);
ray_error_free(msg);
Expand All @@ -1241,7 +1243,8 @@ ray_t* ray_ipc_send_verbose(int64_t handle, ray_t* msg)
{
bool owned = false;
if (ray_is_lazy(msg)) {
msg = ray_lazy_materialize(msg);
ray_retain(msg);
msg = ray_lazy_materialize(msg); /* consumes the retain */
if (RAY_IS_ERR(msg)) return msg;
owned = true;
}
Expand Down
3 changes: 2 additions & 1 deletion src/store/serde.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,8 @@ ray_t* ray_de(ray_t* bytes) {
ray_err_t ray_obj_save(ray_t* obj, const char* path) {
bool owned = false;
if (ray_is_lazy(obj)) {
obj = ray_lazy_materialize(obj);
ray_retain(obj);
obj = ray_lazy_materialize(obj); /* consumes the retain */
if (RAY_IS_ERR(obj)) {
ray_err_t code = ray_err_from_obj(obj);
ray_error_free(obj);
Expand Down
Loading