added dir rendering capability and additional templating mechanism #54

Closed
wants to merge 13 commits into
from

Projects

None yet

2 participants

@zcaudate

please check out the changes I have made.... It is stable but needs more testing and more eyes to look at the code before i'm confident enough to say it is ready for production

The current version does not break any of the original lein-newnew functionality but due to some difficulty in working with the original code when I was adding in the 'rendering directories' function, I'm proposing some changes for how templates should be written in the future.

Advantages:

  • templating entire directories
  • simpler templating mechanism, easy to copy and paste entire projects as templates as opposed to manually doing it like before.

yet to do

  • additional commands that can be run

This is in the leiningen.newnew folder. I've also re-jigged the 4 builtin templates to work with my changes.

the Readme will give the overall picture of what I was trying to do.

@zcaudate

Anyone there?

I've added another template example https://github.com/zcaudate/blank-zurb-website

@Raynes
Owner

This is pretty much a complete rewrite of everything. Going to need some time.

@zcaudate

no worries =) I was more looking to get some feedback... do let me know if anything needs to be put in (docs, comments, etc...)

@Raynes
Owner

Just wanted to let you know I haven't forgotten about this. I've just been busy. I'll get to it as soon as possible.

@zcaudate
@Raynes
Owner

The plugin is in leiningen itself's codebase. A lot of templates have been created against the current new task, so it would be hugely disrupting to introduce backwards incompatible changes. However, if you still think this patch is a good idea, please open it against Leiningen itself. Keep in mind that it'll very likely be leiningen 3.0.0 before any backwards incompatible changes can be introduced.

@Raynes Raynes closed this Feb 1, 2013
@zcaudate

The plugin IS actually backwards compatible with the old system as I am currently using it with other templates. So people can create templates using both the standard way as well as the new way.... I just added that deprecation notice for versioning reasons. I know what you mean about the changes - there is quite a bit. However the template system will be a lot cleaner and a lot more powerful when done this way. So what is happening with this current repository? will there be any new developments?

@Raynes
Owner

Oh. I didn't know that. Sure would have made it easier to get this reviewed. I apologize!

There will be no new development on this repository. All of it has moved to Leiningen's codebase, so these changes will need to be made there. I know that that is a lot of trouble, and I'm very sorry I didn't get this reviewed while this repository was active. The good news is that there will be plenty of other eyes on it once it's a pull request on Leiningen's repo.

Once again, sorry for all the trouble.

@zcaudate zcaudate referenced this pull request in technomancy/leiningen Feb 7, 2013
Closed

A better templating system for leiningen #990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment