New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid using EXTPTR_PTR #1097
Comments
|
Sure, good catch. Saw that discussion, and of course the ping-pong between @gaborcsardi and myself about the Which, almost surely, is not related to the Let me chew over if I want to tackle this this week or rather ship what we have now as 1.0.5 and then let a change such as this "rest and mature" a little en route to 1.0.6. If that release happens. Because I am still not over the nonsense I had to put up with in the discussion after 1.0.4 came out, and we had risked late changes. Very little appetite for repeating that.... |
|
I mistook the reference from |
|
By the same token this and the code below in the same file may need a rethink: Line 24 in 97222bb
|
|
Hm, and Ok, it is in the 'else' branch of |
As it's not part of the official R API. See https://r.789695.n4.nabble.com/Possible-ABI-change-in-R-4-0-1-td4764335.html for details.
We should use
R_ExternalPtrAddtr()instead.Evidently this change was done way back in 2011 as well for some usages:
Rcpp/ChangeLog
Lines 6630 to 6634 in b125470
The text was updated successfully, but these errors were encountered: