-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use documented R API function for extptr addr #1098
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
===========================================
+ Coverage 75.35% 95.61% +20.25%
===========================================
Files 64 64
Lines 2784 2784
===========================================
+ Hits 2098 2662 +564
+ Misses 686 122 -564
|
Thanks, on balance I think this will have to wait til after 1.5.0 is out. |
3ed0329
to
2f69b28
Compare
I rebased this against Ok with you I hope? ;-) |
LGTM -- thanks! |
I was a little slow preparing a new rev.dep check for this 1.0.5.1 rc, but it is running. I may give a few hours, or maybe even wait til tomorrow, to see all is ok as expected and then merge. |
It's over 1/3 done and looking reasonable so far, so merging this now. |
Just for completeness: no issue came up, the reverse depends check concluded just fine, and I just commited the summary to the usual |
Closes #1097.
"In theory" this PR should be safe ... but I'd definitely understand if we still don't want to take it so close to release.
Checklist
R CMD check
still passes all tests