Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vignettes premade (closes #1004) #1005

Merged
merged 9 commits into from Oct 27, 2019
Merged

Conversation

@eddelbuettel
Copy link
Member

eddelbuettel commented Oct 26, 2019

See #1004 for discussion.

In a nutshell:

  • we build vignettes from Rmd "locally", and then
  • include them via the LaTeX / Sweave command \includepdf 'as is' into simple wrapper document
  • speeds up package build a little
  • renders it independent of tooling changes on the vignette side (pinp, rmarkdown, ...)
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 26, 2019

Codecov Report

Merging #1005 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files          63       63           
  Lines        3164     3164           
=======================================
  Hits         2609     2609           
  Misses        555      555

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3e878...4d2be5b. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Copy link
Member Author

eddelbuettel commented Oct 26, 2019

@kevinushey I know you already nodded at #1004 but if you have a minute or two this weekend to glance at this I'd appreciate it.

@eddelbuettel eddelbuettel merged commit 15dee28 into master Oct 27, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/vignettes_premade branch Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.