Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new test for version number consistency (fixes #1021) #1022

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

eddelbuettel
Copy link
Member

As mentioned in #1021, the entries in config.h can become disconnected from packageVersio(). This PR ties them back together via a simple set of unit tests.

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member Author

We can still experiment with a helper script on top keeping DESCRIPTION and config.h tied, but at least now we have checks to go with missing balances :)

@eddelbuettel eddelbuettel merged commit 8580d28 into master Nov 13, 2019
@eddelbuettel eddelbuettel deleted the feature/check_version branch November 13, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants