Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tinytest #1028

Merged
merged 24 commits into from
Nov 27, 2019
Merged

Feature/tinytest #1028

merged 24 commits into from
Nov 27, 2019

Conversation

eddelbuettel
Copy link
Member

This switches Rcpp from RUnit to tinytest, similar to the conversion in a done of other repos.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Document the changes by file in ChangeLog

skipping both for now for side effects, and binary package input is stale
skipping both for now for side effects, and binary package input is stale
@eddelbuettel
Copy link
Member Author

@kevinushey @jjallaire -- if you have a chance to review, I would appreciate it.

This "only" moves us from RUnit to tinytest, removing one helper file in R/ (to approximate poorly what tinytest gives us for free, tests from the installed package) but has of course a lot of changes in inst/tinytest relative to inst/unitTests.

There is a bit more tuning to do -- I am currently "parking" tests that create a lot of noise on the command-line (test of package installation) and I think I want to make those conditional on a new env var just how we now have one that turns on/off with majors like 1.0.3 ("off") or 1.0.3.2 ("on"). If the var is set, doing tinytest::run_test_dir("inst/tinytest/") gives you this:

edd@rob:~/git/rcpp(feature/tinytest)$ Rscript -e 'tinytest::run_test_dir("inst/tinytest")'
Running test_algorithm.R..............   34 tests OK
Running test_as.R.....................   36 tests OK
Running test_attributes.R.............    6 tests OK
Running test_binary_package.R.........    0 tests   
Exited 'test_binary_package.R' at line 33. Skipping 'test_binary_package.R'
Running test_client_package.R.........    0 tests
Exited 'test_client_package.R' at line 30. Skipping 'test_client_package.R'
Running test_dataframe.R..............   15 tests OK
Running test_date.R...................   58 tests OK
Running test_dispatch.R...............   13 tests OK
Running test_embedded_r.R.............    0 tests
Exited 'test_embedded_r.R' at line 26. Skipping 'test_embedded_r.R'
Running test_environments.R...........   81 tests OK
Running test_exceptions_nocall.R......    4 tests OK
Running test_exceptions.R.............   29 tests OK
Running test_expose_class.R...........    0 tests
Exited 'test_expose_class.R' at line 26. Skipping 'test_expose_class.R'
Running test_function.R...............   22 tests OK
Running test_interface.R..............    0 tests
Exited 'test_interface.R' at line 26. Skipping 'test_interface.R'
Running test_internal_function_cpp11.R    2 tests OK
Running test_internal_function.R......    2 tests OK
Running test_language.R...............   45 tests OK
Running test_listof.R.................   16 tests OK
Running test_matrix.R.................   76 tests OK
Running test_misc.R...................   50 tests OK
Running test_modref.R.................    4 tests OK
Running test_module_client_package.R..    0 tests
Exited 'test_module_client_package.R' at line 35. Skipping 'test_module_client_package.R'
Running test_module.R.................   28 tests OK
Running test_na.R.....................    7 tests OK
Running test_packageversion.R.........    4 tests OK
Running test_quickanddirty.R..........    5 tests OK
Running test_rcpp_package_skeleton.R..    0 tests
Exited 'test_rcpp_package_skeleton.R' at line 26. Skipping 'test_rcpp_package_skeleton'
Running test_reference.R..............    0 tests
Exited 'test_reference.R' at line 26. Skipping 'test_reference.R'
Running test_rmath.R..................  102 tests OK
Running test_robject.R................   90 tests OK
Running test_s4.R.....................   20 tests OK
Running test_stack.R..................   30 tests OK
Running test_stats.R..................   36 tests OK
Running test_string.R.................   15 tests OK
Running test_subset.R.................   19 tests OK
Running test_sugar_var.R..............    5 tests OK
Running test_sugar.R..................  447 tests OK
Running test_support.R................    5 tests OK
Running test_system.R.................    7 tests OK
Running test_table.R..................    4 tests OK
Running test_vector_old.R.............    2 tests OK
Running test_vector.R.................    0 tests    Vector.cpp: In function ‘void no_op(int)’:
Vector.cpp:808:9: warning: unused variable ‘minor’ [-Wunused-variable]
     int minor = 1;
         ^~~~~
Running test_vector.R.................  137 tests OK
Running test_wrap.R...................   41 tests OK
Running test_wstring.R................    4 tests OK
Running test_xptr.R...................    6 tests OK
[1] "All ok, 1507 results"
edd@rob:~/git/rcpp(feature/tinytest)$

Similarly, tinytest::test_package("Rcpp", ncpu=4) runs the installed package.

@eddelbuettel
Copy link
Member Author

There is also a little bit of 'crayon'-style color. Here is what testing the installed package looks like:

image

@eddelbuettel eddelbuettel merged commit 4f438b6 into master Nov 27, 2019
@eddelbuettel eddelbuettel deleted the feature/tinytest branch December 3, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants