Skip to content

Conversation

eddelbuettel
Copy link
Member

This addresses the (spurious but tedious) one warning in #1152, and while we are at it, updates in that file alone the few uses of unsigned int to uint32_t. The second part is more debatable but should be harmless and does of course test out fine.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Due to their similarities, maybe it's a good opportunity to switch to uint32_t in SelfHash.h too.

@eddelbuettel
Copy link
Member Author

Due to their similarities, maybe it's a good opportunity to switch to uint32_t in SelfHash.h too.

Agreed. I already did a recursive grep and it is very few files. But not urgent, and I wanted to keep this small.

Thanks for the review!

@eddelbuettel eddelbuettel merged commit 27f24f0 into master Apr 10, 2021
@eddelbuettel eddelbuettel deleted the issue1152 branch April 10, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants