Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cfloat header (fixes #1161) #1162

Merged
merged 2 commits into from
May 13, 2021
Merged

add cfloat header (fixes #1161) #1162

merged 2 commits into from
May 13, 2021

Conversation

eddelbuettel
Copy link
Member

As seen in #1158 and described in #1161, we are apparently missing cloat (or float.h) for numeric limits. This small commit addresses this.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #1162 (7bfec31) into master (27f24f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1162   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          64       64           
  Lines        2783     2783           
=======================================
  Hits         2712     2712           
  Misses         71       71           
Impacted Files Coverage Δ
inst/include/RcppCommon.h 100.00% <ø> (ø)

@eddelbuettel
Copy link
Member Author

No objections by anyone so will likely merge this 'soon' ...

@kevinushey
Copy link
Contributor

LGTM as well.

My only question is whether this could cause problems on "certain systems" if the user had used #include <float.h> before #include <Rcpp.h>, but I suspect it will be fine.

@eddelbuettel
Copy link
Member Author

I think all 'library' header files have include guards. Having worked on #1158 I have seen quite a few 'include header sections' in the wild and I don't think there is an issue.

@eddelbuettel
Copy link
Member Author

Oh, and I just ran a full rev.dep check with #include <cfloat> added. I haven't looked at in detail but it does not seem to have set the world on fire :)

@eddelbuettel
Copy link
Member Author

I just committed the summary of that rev.dep run and nothing new came up.

As usual a few unrelated issues at CRAN but by and large the number of packages affected by adding the desired STRICT_R_HEADERS (cf #1158) comes down so moving in the right direction

@eddelbuettel eddelbuettel merged commit c172a06 into master May 13, 2021
@eddelbuettel eddelbuettel deleted the feature/cfloat_header branch May 13, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants