Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update old examples with respect to RNGScope (closes #1172) #1173

Merged
merged 2 commits into from
Sep 6, 2021

Conversation

eddelbuettel
Copy link
Member

A fresh entry for the Rcpp Gallery came with explicit uses of RNGScope, something we have not needed 'since forever' so I took a quick look at the examples and a) removed one entry and b) used stronger language on the old inline examples.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #1173 (1b8193e) into master (423a2ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1173   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          64       64           
  Lines        2783     2783           
=======================================
  Hits         2712     2712           
  Misses         71       71           

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the typo, LGTM.

inst/examples/RcppGibbs/timeRNGs.R Outdated Show resolved Hide resolved
@eddelbuettel eddelbuettel merged commit a50c8d8 into master Sep 6, 2021
@eddelbuettel eddelbuettel deleted the bugfix/remove_rngscope_from_examples branch September 6, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants