Skip to content

Conversation

eddelbuettel
Copy link
Member

This removes the now-redundant .travis.yml file and the link from the README.md as Travis CI decided to give us all the cold shoulder (I am tempted to insert more colourful language here...)

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

also fix one typo, and standardize some tests for external pointer
@eddelbuettel
Copy link
Member Author

This being a somewhat minor and procedural issue I am allowing myself a pass on the 'not yet approved' front and will merge.

@eddelbuettel eddelbuettel merged commit 940fb23 into master Dec 1, 2021
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel deleted the feature/prune_travis branch December 1, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants