Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zero row data frame push back/front (closes #1232) #1233

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Support zero row data frame push back/front (closes #1232) #1233

merged 3 commits into from
Oct 7, 2022

Conversation

eddelbuettel
Copy link
Member

Rationale

This PR addresses the issue identified in #1232 where one cannot push (back or front) into zero-row data.frame objects.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Enchufa2
Enchufa2 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit b6d25ce into master Oct 7, 2022
@eddelbuettel eddelbuettel deleted the feature/zero_row_data_frame_push_back branch October 7, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enchufa2 Enchufa2 Enchufa2 approved these changes

@kevinushey kevinushey Awaiting requested review from kevinushey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddelbuettel @Enchufa2