Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address a warning from g++-12 #1241

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Address a warning from g++-12 #1241

merged 1 commit into from
Jan 9, 2023

Conversation

eddelbuettel
Copy link
Member

This micro PR is a follow-up from #1240 and silences a warning now created by g++-12. The change is included in the reverse-depends check now running.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Enchufa2
Enchufa2 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, that size() method returns int. LGTM!

@eddelbuettel eddelbuettel merged commit b57c7f7 into master Jan 9, 2023
@eddelbuettel eddelbuettel deleted the feature/g++_warning branch January 9, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enchufa2 Enchufa2 Enchufa2 approved these changes

@kevinushey kevinushey Awaiting requested review from kevinushey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddelbuettel @Enchufa2