Skip to content

Conversation

eddelbuettel
Copy link
Member

As discussed in #1255, we have (at least) one remaining case of using apostrophes instead of backticks in the generated file R/RcppExports.R created by compileAttributes().

The narrow fix is simple, the wider issue may be to determine if there are other parts that need updating. We can keep the PR open for a bit to discuss.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member Author

One more change, possibly. I just more-or-less tried to close the circle and help @edzer with this PR r-spatial/sf#2127 and I noticed that there (using the version from this PR) we (once I added , registration=TRUE which sf was lacking) write this as

# Register entry points for exported C++ functions
methods::setLoadAction(function(ns) {
    .Call(`_sf_RcppExport_registerCCallable`, PACKAGE = 'sf')
})

I probably want to take the , PACKAGE = 'sf' out, no?

@kevinushey
Copy link
Contributor

Good catch, I think that's correct.

@eddelbuettel
Copy link
Member Author

eddelbuettel commented Mar 19, 2023

Yeah, I also casually tested it with my package and the PR for sf. I think this is now good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants