Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rcpp-FAQ vignette #1284

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Update Rcpp-FAQ vignette #1284

merged 3 commits into from
Nov 12, 2023

Conversation

eddelbuettel
Copy link
Member

This PR updates the FAQ vignette for which a few entries had gotten a little stale.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Enchufa2
Enchufa2 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member Author

Thanks. I had done an earlier pass a week (or two?) earlier and figured I might as well try to push this across the line now rather than to procrastinate further.

@eddelbuettel eddelbuettel merged commit e52bd46 into master Nov 12, 2023
@eddelbuettel eddelbuettel deleted the feature/faq_update branch November 12, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enchufa2 Enchufa2 Enchufa2 approved these changes

@kevinushey kevinushey Awaiting requested review from kevinushey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddelbuettel @Enchufa2