Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust to -Wformat under R-devel #1285

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Adjust to -Wformat under R-devel #1285

merged 2 commits into from
Nov 24, 2023

Conversation

eddelbuettel
Copy link
Member

Pull Request Template for Rcpp

This PR adjusts two files with changes kindly suggested by @kalibera, and tested under update r-devel.

When used with -Wformat, the compiler no longer complains about incorrect format strings.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Enchufa2
Enchufa2 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit b90ab65 into master Nov 24, 2023
14 checks passed
@eddelbuettel eddelbuettel deleted the bug/printf_format_r-devel branch November 24, 2023 15:14
@clabornd clabornd mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enchufa2 Enchufa2 Enchufa2 approved these changes

@kevinushey kevinushey Awaiting requested review from kevinushey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddelbuettel @Enchufa2