Skip to content

Conversation

eddelbuettel
Copy link
Member

Pull Request Template for Rcpp

As discussed in #1287 we trigger a -Wformat-security nag from the glue code in src/attributes.cpp. The fix is pretty simple: add a missing "%s" format string.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member Author

Thanks @kevinushey -- I'll wait for a complete CI run and will then send a commit rolling this to 1.0.11.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants