Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condition define of no remap #1296

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Condition define of no remap #1296

merged 2 commits into from
Feb 21, 2024

Conversation

eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Feb 21, 2024 •
edited
Loading

R 4.4.0 will likely define R_NO_REMAP so we need to protect our (currently unconditional) definition.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

kevinushey
kevinushey approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit c63bae6 into master Feb 21, 2024
14 checks passed
@eddelbuettel eddelbuettel deleted the feature/condition_no_remap branch February 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinushey kevinushey kevinushey approved these changes

@Enchufa2 Enchufa2 Awaiting requested review from Enchufa2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddelbuettel @kevinushey