Skip to content

Conversation

eddelbuettel
Copy link
Member

Issue #1299 alerts to issues from the (very much opt-in, not (yet ?) compulsory) conversion warnings clang++17 can do. As I noticed a few from one of our own tests a first attempt squashed those.

This likely does not 'close' the issue so not adding the tag, but should do no harm.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants