Skip to content

Conversation

Enchufa2
Copy link
Member

I realised that this wasn't a problem with std::endl, but in general with the output of any single character, which is managed by overflow(). The new implementation of overflow() calls xsputn(), and it works correctly in SPARC too.

@eddelbuettel
Copy link
Member

Nice detective work, congrats, and what looks like a clean patch (with arguably "criminal" placement of curly braces :) )

@Enchufa2
Copy link
Member Author

:D Do you prefer the opening brace in the previous line?

@codecov-io
Copy link

codecov-io commented Feb 14, 2017

Codecov Report

Merging #649 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          65       65           
  Lines        3309     3309           
=======================================
  Hits         3064     3064           
  Misses        245      245
Impacted Files Coverage Δ
inst/include/Rcpp/iostream/Rstreambuf.h 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99737e...a82ce37. Read the comment docs.

@eddelbuettel
Copy link
Member

Yes, I tend to still write opening curlies on the same line as if or for or function or ...

@Enchufa2
Copy link
Member Author

Solved!

@eddelbuettel
Copy link
Member

That wasn't strictly needed but I appreciate it.

@eddelbuettel eddelbuettel merged commit d96fcc0 into RcppCore:master Feb 14, 2017
@eddelbuettel
Copy link
Member

eddelbuettel commented Feb 15, 2017

Thanks very much for the bug report, and the fix! This was well done.

We really appreciate the help -- especially on a system we don't generally have access to.

@Enchufa2
Copy link
Member Author

This wouldn't have been possible without the help of Prof. F. Gringoli, from University of Brescia, who revived this decrepit SPARC server for the cause. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants