RcppArmadillo 15.2.1-0 with Armadillo 15.2.1 #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates RcppArmadillo from version 15.2.0-0 to 15.2.1-0, incorporating Armadillo library version 15.2.1. The primary focus is performance optimization for submatrix operations, particularly for single-row submatrices.
Key Changes:
- Optimized memory access patterns for
subview_rowoperations by introducing arowmempointer - Added new utility methods (
fill,zeros,ones,is_finite,has_inf,has_nan) tosubview_rowandsubview_colclasses - Simplified loop implementations to improve performance
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| inst/include/current/armadillo_bits/subview_meat.hpp | Core implementation changes including optimized memory access, new utility methods, and simplified loop structures |
| inst/include/current/armadillo_bits/subview_bones.hpp | Added method declarations and rowmem member variable to support optimizations |
| inst/include/current/armadillo_bits/op_accu_mat.hpp | Updated accumulation operations to use optimized memory access patterns |
| inst/include/current/armadillo_bits/arma_version.hpp | Version bump from 15.2.0 to 15.2.1 |
| inst/NEWS.Rd | Documentation of new release with performance improvements |
| configure.ac, configure, DESCRIPTION, ChangeLog | Version and metadata updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eddelbuettel
force-pushed
the
feature/arma_15.2.1
branch
from
5f3e4f7 to
78eb68b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.