Skip to content

fixes for compilation with Rtools 40 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinushey merged 2 commits into from
Nov 4, 2019
Merged

fixes for compilation with Rtools 40 #101

kevinushey merged 2 commits into from
Nov 4, 2019

Conversation

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Oct 25, 2019

  • set runtime explicitly (no need to try and infer)
  • cscript.exe actually requires options be prefixed with two slashes rather than one
  • invoke with shell rather than cmd.exe

@jeroen
Copy link
Contributor

jeroen commented Oct 26, 2019

Thanks!!

@jeroen
Copy link
Contributor

jeroen commented Nov 2, 2019

LGTM 👍

@kevinushey kevinushey merged commit 5e05387 into master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinushey @jeroen