Update to TBB 2017 Update 7 #48
Conversation
|
If it helped, I could probably run a rev.dep check for this. Per the [RcppParallel] CRAN page(https://cloud.r-project.org/web/packages/RcppParallel/index.html), it is pretty short list of reverse depends. |
|
Thank you, but I already did here. There is an error with |
src/Makevars
Outdated
| # a possible '-m64' attached to the CC variable | ||
| # (or other compiler arguments) | ||
| PKG_CPPFLAGS += $(CXX1XSTD) -I../inst/include/ | ||
| PKG_CPPFLAGS += $(CXX11STD) -I../inst/include/ |
There was a problem hiding this comment.
Does R 3.0.2 understand CXX11STD? (Just because we in theory support R back to that version)
There was a problem hiding this comment.
Hm, I thought that "CXX1X" had been deprecated in favor of "CXX11"?
R versions 3.1.0 to 3.3.3 used CXX1X rather than CXX11, and these forms are deprecated but still accepted.
There was a problem hiding this comment.
Indeed it's been deprecated, but because RcppParallel currently requires R >= 3.0.2, I just wanted to make sure that the package still builds successfully there.
Alternatively, we can just bump the minimum R version in the DESCRIPTION to R 3.1.0?
There was a problem hiding this comment.
Wasn't the CXX1X != CXX11 change done in R 3.4.0? IIRC it still understands the older form but prefers the newer.
|
@eddelbuettel what's your opinion on including the |
|
What folder? For rev.deps I run I keep the logs in this repo. But that is just how my workflow evolved so it doesn't really matter. |
|
I tried my best to track down and preserve all the fixes and modifications for Solaris and Windows but it would be great if someone could double check that it works. The revdep checks now all check out. It turns out I hadn't set up GSL properly. |
|
I'll try building on my Windows VM as well just to double-check that everything is in order. PS: thanks for taking the time to put together this PR, updating TBB here is long overdue! |
|
I tried building this branch with R 3.2.5 and it failed due to CXX11 and CXX11STD not being defined. Can we stick with CXX1X and CXX1XSTD? |
|
(I had to temporarily hijack the maintainer field -- hope that's fine). |
|
This looks like a nicely done job -- thanks Johan! I am technically not a maintainre or author here on this repo so I shouldn't do the merge but someone may pull the trigger... |
4 participants
This pull request updates RcppParallel to use Intel TBB 2017 Update 7. The motivation is both to take advantage of the improvements in TBB and to hopefully fix some issues in RcppParallel. I have also updated the version number to 2017.7.0 to reflect the changed version pattern in TBB and the readme to cover the change of license (from GPL to Apache).
The package has been tested for release, devel, and oldrel for linux (gcc and clang) and release and devel on osx on travis-ci and windows locally, where it checks out okay. There are failures on appveyor, however, that I haven't been able to crack. Solaris has not been tested.
I am sort of out of my depth here so it would be fantastic is someone more proficient could chip in to review this.