Detect GCC version via R instead of ActionScript #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
reviewed
Jul 17, 2018
| ifeq ($(shell expr $(GCC_VERSION) \>= 6.0), 1) | ||
| # keep pre-contruction stores for zero initialization | ||
| DSE_KEY = -flifetime-dse=1 | ||
| COMPILE_ONLY += -flifetime-dse=1 |
Contributor
There was a problem hiding this comment.
This might actually be unneeded since once DSE_KEY is set the rest of the Makefile machinery will propagate it into the compilation flags
Contributor
Author
There was a problem hiding this comment.
From what I can see, that doesn't seem to be the case. Otherwise there wouldn't be a bug with the new toolchain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.