Skip to content

Simplify branching logic inside skip_white()#2208

Merged
mattdowle merged 3 commits intoRdatatable:masterfrom
st-pasha:fread_antisep
Jun 29, 2017
Merged

Simplify branching logic inside skip_white()#2208
mattdowle merged 3 commits intoRdatatable:masterfrom
st-pasha:fread_antisep

Conversation

@st-pasha
Copy link
Copy Markdown
Contributor

The global variable antisep is the "opposite" of sep: when sep is a space antisep is Tab, and vice-versa. If sep is something other than space/Tab, then antisep is 0.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 18, 2017

Codecov Report

Merging #2208 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
+ Coverage   90.74%   90.74%   +<.01%     
==========================================
  Files          59       59              
  Lines       11471    11475       +4     
==========================================
+ Hits        10409    10413       +4     
  Misses       1062     1062
Impacted Files Coverage Δ
src/fread.c 93.14% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786c316...6159dca. Read the comment docs.

@st-pasha st-pasha requested a review from mattdowle June 29, 2017 00:48
@st-pasha st-pasha added the fread label Jun 29, 2017
@mattdowle mattdowle merged commit 7f31c3e into Rdatatable:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants