Replace isFrame with the new API isDataFrame
#6850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since both the NOTE and the new entry point are in current R-devel, test for both R version and SVN revision to account for revisions that lack both the NOTE and the new entry point. Co-Authored-By: Tyson Barrett <t.barrett88@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6850 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 79 79
Lines 14661 14661
=======================================
Hits 14455 14455
Misses 206 206 ☔ View full report in Codecov by Sentry. |
|
Generated via commit 983acd2 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
|
I'm confused, did #6235 get reverted? |
Member
|
Ah, yes it did: #6252 |
MichaelChirico
approved these changes
Mar 4, 2025
Member
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
Thanks for chasing down the revision number.
I guess (?) we could also have tagged to the revision where isFrame() starts generating NOTEs, but I like the functional test (isDataFrame is defined) better.
MichaelChirico
added a commit
that referenced
this pull request
Mar 10, 2025
* Replace isFrame with the new API isDataFrame Since both the NOTE and the new entry point are in current R-devel, test for both R version and SVN revision to account for revisions that lack both the NOTE and the new entry point. Co-Authored-By: Tyson Barrett <t.barrett88@gmail.com> * Add a TODO --------- Co-authored-by: Tyson Barrett <t.barrett88@gmail.com> Co-authored-by: Michael Chirico <chiricom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of r87874 we get:
Since both the NOTE and the new entry point are in current R-devel, test for both R version and SVN revision to account for revisions that lack the new entry point. Tested manually on r86699 (the last trunk revision before
isDataFramewas added), r86702 (the revision addingisDataFrame), current trunk. Once R-4.5.0 is released, the test for SVN revision can be removed.See also: #6180, #6244.