fread: avoid UB in leap year cycle calculation#7720
Merged
ben-schwen merged 4 commits intomasterfrom Apr 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7720 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 87 87
Lines 17037 17123 +86
==========================================
+ Hits 16874 16959 +85
- Misses 163 164 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-schwen
approved these changes
Apr 23, 2026
aitap
added a commit
that referenced
this pull request
Apr 23, 2026
* Test case * NEWS item * Don't rely on exact string formatting Co-Authored-By: Kevin Ushey <kevinushey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the fix suggested by @kevinushey. Since R's
Dateclass (and thus IDate) uses year zero, the resulting calculations agree with the system tzcode, although theDateclass generally doesn't like to parse negative years:Fixes: #7704