Draft
Conversation
| WI,USA,East_North_Central,lake-states,Midwest | ||
| WV,USA,South_Atlantic,appalachia,MidAtlantic | ||
| WY,USA,Mountain,mountain,Mountain | ||
| st,country,cendiv,usda_region,h2ptcreg,ngreg |
Contributor
There was a problem hiding this comment.
- How about
gasreginstead ofngreg, since the techs aregas-cc/gas-ctand we don't usengmuch throughout the code? - We'll need to add the new region level to https://reeds-model.github.io/ReEDS/model_documentation.html#figure-hierarchy (and describe the new method in the docs). If the regions are finalized, let me know and I can remake the figure.
Contributor
There was a problem hiding this comment.
gasreg SGTM and thanks for the heads up on the docs. The regions are finalized so if you could remake the figure that'd be great, thanks! Here's the charge code if needed: OOSP >-> 10291 - 05.18.01
| return load_in, load_out | ||
|
|
||
|
|
||
| def get_natgas_price_diffs(sw, hmap_myr, hmap_allyrs, inputs_case, periodtype='rep'): |
Contributor
There was a problem hiding this comment.
Since this file is modified, can you run all the temporal tests from cases_test.csv and make sure they still work?
- Pacific_CC
- Pacific_weks
- Pacific_full_year
- Interday_storage
- Pacific_rep7
…f get_degree_days
kodiobika
requested changes
Apr 30, 2026
Contributor
kodiobika
left a comment
There was a problem hiding this comment.
Thanks for your work on this! It's looking great so far -- mostly just some stylistic suggestions
kodiobika
reviewed
Apr 30, 2026
…liers for both r and cendiv region levels
…daily gas price multipliers for r and cendiv region levels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Technical details
representative hourly NG price multipliers
Implementation notes
----(Daily max + Daily min)/2 - 18.33C
----daily sum (Hourly temp - 18.33C)
Relevant sources or documentation
Validation, testing, and comparison report(s)
Checklist for author
Details to double-check
General information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
Tag points of contact here if you would like additional review of the relevant parts of the model