Skip to content

Fix my mistakes in test setup #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timdorr merged 2 commits into from
Jul 14, 2016
Merged

Fix my mistakes in test setup #3637

timdorr merged 2 commits into from
Jul 14, 2016

Conversation

@taion
Copy link
Contributor

@taion taion commented Jul 14, 2016

  • I don't know why I had a branch to sometimes not run coverage, there's no reason not to always run coverage
  • The Mobile Safari custom browsers had a key collision
  • If we use the ES2015 support in recent Node releases, our random scripts all pass lint again, so we might as well lint them

@timdorr timdorr merged commit e38527f into master Jul 14, 2016
@timdorr timdorr deleted the chore branch July 14, 2016 20:24
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taion @timdorr