Updated types to match native code #336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 3D vector type to updated 3D vector dependant props
nijatkazimliPG
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some error for the property force of physicsBody prop, when doing what the ts linter told it was the correct type it led to a crash in the app due to the prop not receiving the correct type. I looked into it and figured the type for force was not well typed, so here is my proposal.
Added a 3D vector type for the props that expect a 3D vector.
Modified the methods of ViroNode and ViroButton to match the new force type
I opted to handle the type problem this way so the force prop of physics body and the applyImpulse method match now
This PR solves #337