Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
- Coverage 74.50% 74.49% -0.02%
==========================================
Files 103 103
Lines 28114 28121 +7
Branches 5827 5829 +2
==========================================
+ Hits 20946 20948 +2
- Misses 5678 5681 +3
- Partials 1490 1492 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kfir4444
approved these changes
Apr 24, 2025
Collaborator
kfir4444
left a comment
There was a problem hiding this comment.
LGTM, maybe some tests are needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1D rotor scans for large systems fail too often. In some applications we'd like to compute rotors, but if they fail that means that more sophisticated methods should be applied. Currently ARC tries to troubleshoot the rotor runs, taking too long, and not always succeeding. This PR keeps the above default behavior, but adds an option to avoid trshing rotor runs