Skip to content

Added a feature that allows not to trsh rotors#786

Merged
alongd merged 1 commit intomainfrom
trsh_rotors
May 9, 2025
Merged

Added a feature that allows not to trsh rotors#786
alongd merged 1 commit intomainfrom
trsh_rotors

Conversation

@alongd
Copy link
Copy Markdown
Member

@alongd alongd commented Apr 11, 2025

1D rotor scans for large systems fail too often. In some applications we'd like to compute rotors, but if they fail that means that more sophisticated methods should be applied. Currently ARC tries to troubleshoot the rotor runs, taking too long, and not always succeeding. This PR keeps the above default behavior, but adds an option to avoid trshing rotor runs

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.49%. Comparing base (155f5af) to head (c9d88af).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
arc/main.py 16.66% 3 Missing and 2 partials ⚠️
arc/scheduler.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   74.50%   74.49%   -0.02%     
==========================================
  Files         103      103              
  Lines       28114    28121       +7     
  Branches     5827     5829       +2     
==========================================
+ Hits        20946    20948       +2     
- Misses       5678     5681       +3     
- Partials     1490     1492       +2     
Flag Coverage Δ
unittests 74.49% <22.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alongd alongd requested a review from samcogan21 April 21, 2025 20:15
Copy link
Copy Markdown

@samcogan21 samcogan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@kfir4444 kfir4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe some tests are needed?

@alongd alongd merged commit b38742a into main May 9, 2025
7 of 9 checks passed
@alongd alongd deleted the trsh_rotors branch May 9, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants