Improved the xTB parser#856
Merged
LeenFahoum merged 4 commits intomainfrom Apr 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves ARC’s xTB parsing behavior and strengthens regression coverage for common xTB log output edge cases.
Changes:
- Fix xTB 1D scan angle generation so returned
anglesandenergieslengths match. - Improve xTB parsing robustness for frequencies (use last eigval block), ZPE parsing (regex), energy parsing (avoid “total energy gain” false match), geometry parsing (reset on new blocks), and basic error detection.
- Add targeted unit tests covering the above xTB-specific behaviors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
arc/parser/parser_test.py |
Updates 1D scan expectations and adds xTB-focused regression tests for energy/frequency/ZPE/geometry/error detection. |
arc/parser/adapters/xtb.py |
Implements xTB parser robustness improvements (error detection, geometry block reset, eigval-block selection, regex parsing, angle-length fix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
==========================================
+ Coverage 60.08% 60.09% +0.01%
==========================================
Files 102 102
Lines 31041 31045 +4
Branches 8082 8087 +5
==========================================
+ Hits 18651 18658 +7
+ Misses 10076 10071 -5
- Partials 2314 2316 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7753fd4 to
3a846d3
Compare
LeenFahoum
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.