Update copyright and file headers #1277
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
+ Coverage 43.46% 43.47% +<.01%
==========================================
Files 170 170
Lines 28249 28253 +4
Branches 5496 5496
==========================================
+ Hits 12278 12282 +4
Misses 15135 15135
Partials 836 836
Continue to review full report at Codecov.
|
amarkpayne
left a comment
amarkpayne
left a comment
There was a problem hiding this comment.
This is an awesome PR! There a just a couple of quick fixes that need to be done, but other than that it looks good to go. Make the changes, update the branch, and then I'll merge it in. Awesome job with the script! It will save us a lot of time in the future.
update_headers.py
Outdated
|
|
||
| print header | ||
|
|
||
| def replace_header(file): |
There was a problem hiding this comment.
This won't affect anything, but you might want to change the name file since it file() is already defined in python. You could try something like old_file. Again, this won't affect anything (besides highlighting as Github thinks it is a function and doesn't know better), so if you'd rather just leave it that is fine by me
rmgpy/qm/symmetry.py
Outdated
|
|
||
| """ | ||
| Created on Apr 29, 2012 | ||
| @author: nmvdewie and rwest |
There was a problem hiding this comment.
Should we keep statements like this?
| @@ -1,0 +1,3 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
There was a problem hiding this comment.
It did not copy over the license because this file was completely blank. I think if you manually add the license this one time it will work in the future. That or we should modify your script to handle this case.
| @@ -1,0 +1,3 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| @@ -1,29 +1,3 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
|
|
||
| ''' | ||
| Created on Feb 26, 2013 | ||
There was a problem hiding this comment.
Should we keep the comment below this line?
| @@ -1,3 +1,31 @@ | |||
| # This file describes the version of RMG-Py | |||
There was a problem hiding this comment.
This line gets removed accidently
|
I removed the author tags as we discussed. Let me know when you've reviewed the new commits, and then I'll rebase and squash. |
amarkpayne
left a comment
amarkpayne
left a comment
There was a problem hiding this comment.
Everything looks good! Update this branch and then I will merge it in
mliu49
force-pushed
the
update_headers
branch
from
e110fca to
5e02bed
Compare
mliu49
force-pushed
the
update_headers
branch
from
5e02bed to
cb86749
Compare
amarkpayne
removed
the
Status: Ready for Review
This PR updates the copyright date in the LICENSE.txt file. It also adds a new script to automatically update all file headers based on the LICENSE.txt file and updates the headers with that script.
To review, check the diffs to make sure no important lines were accidentally lost.
Small note: Some manual changes were needed before I ran the script the first time since the file headers were not uniform. The script as it is now works properly with the updated files, so updating headers in the future should be pretty painless.