Skip to content

Aromatic libraries#116

Merged
nyee merged 2 commits intomasterfrom
Aromatic_libraries
Jul 20, 2016
Merged

Aromatic libraries#116
nyee merged 2 commits intomasterfrom
Aromatic_libraries

Conversation

@zjburas
Copy link
Copy Markdown
Contributor

@zjburas zjburas commented Jul 20, 2016

Adding four aromatic libraries from literature:

  1. Fascella
  2. Kislov
  3. Chernov
  4. Narayanaswamy

@nyee nyee force-pushed the Aromatic_libraries branch from 2c664a0 to dc69f5d Compare July 20, 2016 19:29
@nyee nyee merged commit 4748b00 into master Jul 20, 2016
@nyee nyee deleted the Aromatic_libraries branch July 20, 2016 19:40
@PengZhang13
Copy link
Copy Markdown
Contributor

Looks like we have crazy thermo for CH2HCO in Chernov library, as shown here.
All the libraries agree well with each other except Chernov library.
I checked the NASA polynomial. It's same to the source paper. So it's not because our typo.
Since we already have good thermo for this species in other libraries, maybe we could just delete it from this library? Not sure if it affects any projects....

@zjburas
Copy link
Copy Markdown
Contributor Author

zjburas commented Oct 19, 2016

@PengZhang13 , yes, that species can be deleted from Chernov. In fact, the main purpose of both the Chernov and Narayanaswamy libraries was to provide estimates for aromatic thermo and kinetics, so really all non-aromatic species and reactions could be removed from these libraries without defeating their original purpose. I already have "aromatics only" versions of these libraries that I could push to the master if there is interest in that.

@PengZhang13
Copy link
Copy Markdown
Contributor

@zjburas I see. Thanks. I checked the thermo for other small molecules in Chernov. They looked reasonable for me. So maybe we could just delete the crazy one (CH2HCO) and keep the others. Or you could push the 'aromatics only' versions if you don't believe their estimation for non-aromatic molecules. The point is I think we need to make sure the data in the libraries are reasonable, to avoid any potential trouble caused by unintentional usage. In my case, I'm trying to convert a kinetics library to a chemkin file using a script in RMG-database/scripts. The script doesn't specify any specific thermo libraries for the conversion. So in the exported chemkin file, the thermo for CH2HCO was taken from Chernov, which finally caused weird behavior in the subsequent simulation. That's how I find out the thermo for this species is not reasonable.

@zjburas
Copy link
Copy Markdown
Contributor Author

zjburas commented Oct 21, 2016

@PengZhang13 ok. We will have to update both the Chernov and Narayanaswamy aromatic libraries soon anyway to make all of the aromatic have benzene bonds according to @mliu49 , so maybe at that time we can decide if we want to make any other changes to them, i.e., delete all non-aromatic containing reactions and species. Chernov certainly has some questionable small molecule kinetics (e.g., C2H6 = C2H4 + H2) that are probably not valuable to keep, especially since we have much better libraries for these types of reactions like FFCM.

JacksonBurns pushed a commit that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants