Fix carbene chemistry in Klippenstein_Glarborg2016#607
Merged
xiaoruiDong merged 1 commit intomainfrom Feb 24, 2023
Merged
Conversation
xiaoruiDong
force-pushed
the
fix_kg2016
branch
from
cfb6de1 to
2388266
Compare
In the Klippenstein_Glarborg2016 kinetic library, several singlet and triplet carbene reactions are wrongly lumped together. This PR fixes this issue.
xiaoruiDong
force-pushed
the
fix_kg2016
branch
from
2388266 to
6996347
Compare
kspieks
approved these changes
Feb 24, 2023
Contributor
kspieks
left a comment
kspieks
left a comment
There was a problem hiding this comment.
Thanks for this PR which has an important bug fix! Can you include the original chemkin mechanism file (or maybe a link to it) in this PR discussion just so developers can easily refer to it from this PR in the future? Thanks again!
Contributor
Author
|
Upload the corresponding mechanism file per request. klippenstein_Glarborg2016.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Klippenstein_Glarborg2016 kinetic library, several singlet and triplet carbene reactions are wrongly lumped together. This PR fixes this issue. The problematic reactions are listed below