This repository was archived by the owner on Apr 20, 2018. It is now read-only.
Use EventEmitter.removeListener instead of the nonexistent 'off' method#52
Closed
duncanmak wants to merge 1 commit intoReactive-Extensions:masterfrom
Closed
Use EventEmitter.removeListener instead of the nonexistent 'off' method#52duncanmak wants to merge 1 commit intoReactive-Extensions:masterfrom
duncanmak wants to merge 1 commit intoReactive-Extensions:masterfrom
Conversation
method.
Without this patch, you get an error that looks like this:
TypeError: Object #<ReadStream> has no method 'off'
at null.action (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.node.js:145:24)
at Disposable.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:612:18)
at SingleAssignmentDisposablePrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:701:17)
at AutoDetachObserverPrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:4668:20)
at SingleAssignmentDisposablePrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:701:17)
at AutoDetachObserverPrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:4668:20)
at CompositeDisposablePrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:554:39)
at null.action (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.binding.js:524:49)
at Disposable.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:612:18)
at SingleAssignmentDisposablePrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:701:17)
mattpodwysocki
added a commit
that referenced
this pull request
Oct 22, 2013
Member
|
Fixed as of 7265876 |
Member
|
Thanks for the PR, I just realized how many other people had noticed the same thing. ugh! |
bouzuya
pushed a commit
to bouzuya/RxJS
that referenced
this pull request
Mar 23, 2016
re-add dist files (oops)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
method.
Without this patch, you get an error that looks like this:
TypeError: Object # has no method 'off'
at null.action (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.node.js:145:24)
at Disposable.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:612:18)
at SingleAssignmentDisposablePrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:701:17)
at AutoDetachObserverPrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:4668:20)
at SingleAssignmentDisposablePrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:701:17)
at AutoDetachObserverPrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:4668:20)
at CompositeDisposablePrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:554:39)
at null.action (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.binding.js:524:49)
at Disposable.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:612:18)
at SingleAssignmentDisposablePrototype.dispose (/Users/duncan/git/duncanmak/test-project/node_modules/rx/rx.js:701:17)