Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

Sorting out debounce/throttle/withSelector methods.#647

Merged
mattpodwysocki merged 1 commit intoReactive-Extensions:masterfrom
gordey4doronin:feature/rxtime-definitions
Apr 1, 2015
Merged

Sorting out debounce/throttle/withSelector methods.#647
mattpodwysocki merged 1 commit intoReactive-Extensions:masterfrom
gordey4doronin:feature/rxtime-definitions

Conversation

@gordey4doronin
Copy link
Copy Markdown
Contributor

  • fixes for rx-time.js debounce/throttle methods definitions (rx.time.d.ts and rx.time-lite.d.ts)
  • throttleWithSelector JSDoc deprecated comment added
  • throttleWithSelector now uses direct call instead of prototype.apply

 - fixes for rx-time.js debounce/throttle methods definitions (rx.time.d.ts and rx.time-lite.d.ts)
 - throttleWithSelector JSDoc deprecated comment added
 - throttleWithSelector now uses direct call instead of prototype.apply
@ghost ghost added the cla-not-required label Apr 1, 2015
@gordey4doronin
Copy link
Copy Markdown
Contributor Author

How deprecated typescript methods looks in webstorm you can check on screenshots attached.

Also put a comment here, explaining why removing methods from *.d.ts was bad.
https://github.com/GDoronin/RxJS/commit/4c81460259020fd7d94e58faeb40f10a66efde69#commitcomment-10504515

screenshot 2015-04-01 02 28 51
screenshot 2015-04-01 02 29 41

mattpodwysocki added a commit that referenced this pull request Apr 1, 2015
Sorting out debounce/throttle/withSelector methods.
@mattpodwysocki mattpodwysocki merged commit 0c6ed4a into Reactive-Extensions:master Apr 1, 2015
@gordey4doronin gordey4doronin deleted the feature/rxtime-definitions branch September 23, 2015 04:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants