This repository was archived by the owner on Apr 20, 2018. It is now read-only.
TypeScript: Fixed a problem with the _Accumulator rewrite in grunt.#879
Merged
mattpodwysocki merged 2 commits intoReactive-Extensions:masterfrom Aug 27, 2015
baltie:ts-definitons-accumulators
Merged
TypeScript: Fixed a problem with the _Accumulator rewrite in grunt.#879mattpodwysocki merged 2 commits intoReactive-Extensions:masterfrom baltie:ts-definitons-accumulators
mattpodwysocki merged 2 commits intoReactive-Extensions:masterfrom
baltie:ts-definitons-accumulators
Conversation
added 2 commits
August 27, 2015 12:06
The result of the rewrite for an accumulator should have been: ((acc: TAcc, value: T) => TAcc) But it was: ((acc: T, value: T) => TAcc)
|
Hi @baltie, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution! TTYL, MSOTBOT; |
|
@baltie, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
mattpodwysocki
added a commit
that referenced
this pull request
Aug 27, 2015
TypeScript: Fixed a problem with the _Accumulator rewrite in grunt.
Contributor
Author
|
Thanks, @mattpodwysocki! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of the rewrite for an accumulator should have been:
((acc: TAcc, value: T) => TAcc)
But it was:
((acc: T, value: T) => TAcc)