Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

TypeScript: Fixed a problem with the _Accumulator rewrite in grunt.#879

Merged
mattpodwysocki merged 2 commits intoReactive-Extensions:masterfrom
baltie:ts-definitons-accumulators
Aug 27, 2015
Merged

TypeScript: Fixed a problem with the _Accumulator rewrite in grunt.#879
mattpodwysocki merged 2 commits intoReactive-Extensions:masterfrom
baltie:ts-definitons-accumulators

Conversation

@baltie
Copy link
Copy Markdown
Contributor

@baltie baltie commented Aug 27, 2015

The result of the rewrite for an accumulator should have been:
((acc: TAcc, value: T) => TAcc)
But it was:
((acc: T, value: T) => TAcc)

Dan Lewi Harkestad added 2 commits August 27, 2015 12:06
The result of the rewrite for an accumulator should have been:
((acc: TAcc, value: T) => TAcc)
But it was:
((acc: T, value: T) => TAcc)
@ghost
Copy link
Copy Markdown

ghost commented Aug 27, 2015

Hi @baltie, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

@ghost ghost added the cla-required label Aug 27, 2015
@ghost
Copy link
Copy Markdown

ghost commented Aug 27, 2015

@baltie, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSOTBOT;

@ghost ghost added cla-signed and removed cla-required labels Aug 27, 2015
mattpodwysocki added a commit that referenced this pull request Aug 27, 2015
TypeScript: Fixed a problem with the _Accumulator rewrite in grunt.
@mattpodwysocki mattpodwysocki merged commit adf137e into Reactive-Extensions:master Aug 27, 2015
@baltie
Copy link
Copy Markdown
Contributor Author

baltie commented Aug 31, 2015

Thanks, @mattpodwysocki!

@baltie baltie deleted the ts-definitons-accumulators branch August 31, 2015 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants