Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

tryCatch no longer uses global state to pass the target#880

Merged
mattpodwysocki merged 1 commit intoReactive-Extensions:masterfrom
fghibellini:master
Aug 27, 2015
Merged

tryCatch no longer uses global state to pass the target#880
mattpodwysocki merged 1 commit intoReactive-Extensions:masterfrom
fghibellini:master

Conversation

@fghibellini
Copy link
Copy Markdown
Contributor

  • your "Our contribution guidelines" link in the readme is broken
  • passing the error in a global variable should also be avoided (new errors wipe the old ones),
    if needed in the tests a better solution would be to push the errors into a global queue.

@ghost
Copy link
Copy Markdown

ghost commented Aug 27, 2015

Hi @fghibellini, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

@ghost ghost added the cla-required label Aug 27, 2015
@mattpodwysocki
Copy link
Copy Markdown
Member

@fghibellini looks great, please sign the CLA and we'll get it merged!

@ghost
Copy link
Copy Markdown

ghost commented Aug 27, 2015

@fghibellini, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSOTBOT;

@ghost ghost added cla-signed and removed cla-required labels Aug 27, 2015
mattpodwysocki added a commit that referenced this pull request Aug 27, 2015
tryCatch no longer uses global state to pass the target
@mattpodwysocki mattpodwysocki merged commit de3d945 into Reactive-Extensions:master Aug 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants