This repository was archived by the owner on Apr 20, 2018. It is now read-only.
Correct argument name and indentation in selectMany docs#881
Merged
mattpodwysocki merged 3 commits intoReactive-Extensions:masterfrom Aug 27, 2015
Merged
Correct argument name and indentation in selectMany docs#881mattpodwysocki merged 3 commits intoReactive-Extensions:masterfrom
mattpodwysocki merged 3 commits intoReactive-Extensions:masterfrom
Conversation
Previously, the name of the argument being passed in to the selectMany with selector example was `count`, when it should have been `x`. The example was also improperly aligned. I have indented it to 4 spaces.
|
Hi @Widdershin, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution! TTYL, MSOTBOT; |
ghost
added
the
mattpodwysocki
added a commit
that referenced
this pull request
Aug 27, 2015
Correct argument name and indentation in selectMany docs
bouzuya
pushed a commit
to bouzuya/RxJS
that referenced
this pull request
Mar 23, 2016
The previous implementation had issues with only calling the source function one time when scheduled. Since bindCallback shares its result with all subscribers, it is multicast, that means that it would need to maintain a list of subscribers internally. In leiu of that, I'm using AsyncSubject (which might need a better name) closes Reactive-Extensions#881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmitting after tidying up all whitespace in file to be 2 space (and fixing a bug I introduced).
Previously, the name of the argument being passed in to the selectMany with selector example was
count, when it should have beenx.